Skip to content

Conversation

@AndrewFerr
Copy link
Member

Instead of using a single "update" method to encompass all update actions (send/restart/cancel), give each action its own method. This makes it easier for widget driver implementations to call the newly-proposed split endpoints for those actions in the CS-API.

Instead of using a single "update" method to encompass all update
actions (send/restart/cancel), give each action its own method.
This makes it easier for widget driver implementations to call the
newly-proposed split endpoints for those actions in the CS-API.
@AndrewFerr
Copy link
Member Author

This PR currently introduces breaking changes to the WidgetApi methods for updating delayed events, and to the WidgetDriver methods for performing the requested update action in a client.

What has not changed is the API between widgets and clients as described in MSC4157.

@AndrewFerr AndrewFerr requested a review from toger5 October 30, 2025 20:39
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apreciate that it gives us the chance to have tests for the action type switch here.

And in general makes it possible to have a widget driver impl that is as easy as possible.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

@AndrewFerr AndrewFerr merged commit 120a290 into master Nov 4, 2025
5 checks passed
@AndrewFerr AndrewFerr deleted the af/delayed-event-management-changes branch November 4, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants